-
Notifications
You must be signed in to change notification settings - Fork 90
Travis: Build binary wheels #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Here are a few wheels to test. Please report whether they work: |
@twmht Do you have questions regarding this PR? 😊 |
@twmht Maybe you have missed this, could you take a look at this? |
Would be nice if this can be merged in. |
env: | ||
global: | ||
- ROCKSDB_COMMIT=479c566771d6464785f205a368701c689e094fe5 | ||
- TWINE_USERNAME=bauerj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this should be changed to an account the maintainers control?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, to quote myself:
In order to automatically upload new releases to PyPi, you should make some changes before merging:
- Set
TWINE_USERNAME
in the.travis.yml
to a username that has access to python-rocksdb on PyPi.- Using the Travis-CI Web Interface, add a hidden
TWINE_PASSWORD
variable for that user: https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, was only reading the code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw it's probably preferable to set username to __token__
and generate an API key specifically for travis on PyPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me; although I haven't tested.
@bauerj - any chance for a new version for python 3.9 since that is default in Debian11? |
This will build manylinux2010 compatible binary wheels for Python 2.7, 3.4, 3.5, 3.6 and 3.7. Manylinux2010 binaries will work on almost any Linux-based system with a C library from 2010 or newer without having to install any dependencies.
The official manylinux2010 Docker image, which is based on ancient Centos 6 is used to compile rocksdb and python-rocksdb.
In order to automatically upload new releases to PyPi, you should make some changes before merging:
TWINE_USERNAME
in the.travis.yml
to a username that has access to python-rocksdb on PyPi.TWINE_PASSWORD
variable for that user: https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settingsOnce this is done, binary wheels for new releases will be automatically uploaded after a new tag is pushed and the tests succeed.
Let me know if you have any questions.
--
Closes: #30