Skip to content

Travis: Build binary wheels #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Travis: Build binary wheels #67

wants to merge 1 commit into from

Conversation

bauerj
Copy link

@bauerj bauerj commented Aug 19, 2019

This will build manylinux2010 compatible binary wheels for Python 2.7, 3.4, 3.5, 3.6 and 3.7. Manylinux2010 binaries will work on almost any Linux-based system with a C library from 2010 or newer without having to install any dependencies.

The official manylinux2010 Docker image, which is based on ancient Centos 6 is used to compile rocksdb and python-rocksdb.

In order to automatically upload new releases to PyPi, you should make some changes before merging:

Once this is done, binary wheels for new releases will be automatically uploaded after a new tag is pushed and the tests succeed.

Let me know if you have any questions.

--
Closes: #30

@bauerj
Copy link
Author

bauerj commented Aug 19, 2019

@bauerj
Copy link
Author

bauerj commented Nov 20, 2019

@twmht Do you have questions regarding this PR? 😊

@bauerj
Copy link
Author

bauerj commented Jun 8, 2020

@twmht Maybe you have missed this, could you take a look at this?

@eterna2
Copy link

eterna2 commented Oct 21, 2020

Would be nice if this can be merged in.

env:
global:
- ROCKSDB_COMMIT=479c566771d6464785f205a368701c689e094fe5
- TWINE_USERNAME=bauerj

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this should be changed to an account the maintainers control?

Copy link
Author

@bauerj bauerj Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, to quote myself:

In order to automatically upload new releases to PyPi, you should make some changes before merging:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, was only reading the code :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw it's probably preferable to set username to __token__ and generate an API key specifically for travis on PyPI

Copy link

@SomberNight SomberNight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me; although I haven't tested.

@SuBPaR42
Copy link

@bauerj - any chance for a new version for python 3.9 since that is default in Debian11?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish binary wheel with RocksDB included
4 participants