Add SO_REUSEPORT support to socket#396
Merged
TysonAndre merged 1 commit intotwitter:masterfrom Oct 6, 2022
Merged
Conversation
ton31337
force-pushed
the
feature/add_socket_reuseport
branch
from
655bb94 to
232648b
Compare
src/nc_stats.c
Outdated
Contributor
There was a problem hiding this comment.
@ton31337 twemproxy can run on mac or freebsd also. so I think you should check other os too not only linux :)
Author
There was a problem hiding this comment.
@charsyam 👍 of course will fix this, but need to be sure if it's worth to spend more time. I mean if it's planned to be merged or not.
ton31337
force-pushed
the
feature/add_socket_reuseport
branch
3 times, most recently
from
daccbb6 to
0ac411f
Compare
Collaborator
|
change looks great - i need to test this before merging. |
|
+1 |
|
|
Author
|
@manjuraj ping |
TysonAndre
requested changes
Sep 27, 2022
ton31337
force-pushed
the
feature/add_socket_reuseport
branch
from
0ac411f to
973886c
Compare
TysonAndre
requested changes
Sep 28, 2022
Introduce new feature for Twemproxy running on newer kernels. With this feature you are able to do upgrades, restarts without any downtime. Kernel does load balancing between processes with the same host:port pairs. Also, helps running on more than single core. Signed-off-by: Donatas Abraitis <donatas@hostinger.com>
ton31337
force-pushed
the
feature/add_socket_reuseport
branch
from
973886c to
3c9cec1
Compare
Collaborator
This seems to work locally - testing since I haven't used SO_REUSEPORT elsewhere. I can start two nutcracker instances for memcached with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SO_REUSEPORT support to socket. Introduce new feature for Twemproxy running on newer kernels. With this feature you are able to do upgrades, restarts without any downtime. Kernel does load balancing between processes with the same host:port pairs.