fix: Type 'void' is not assignable to type 'string' on twemoji.parse typing. #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm checking if we can fix legacy |
|
I cannot find reference to ParseObject in 13.0.0 see usage here:
I guess they have to use 13.0.0 and should be good, this PR does fix bad typing for #532 (comment) and other library that relly on return type for parse. |
|
superseded by #541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look like it was reverted in previous PR commits.
This fix the issue in that comment: #532 (comment)
Once released, i can make a PR to update @joeattardi/emoji-button to use 14.0.2 and fix the issue #534
To reproduce the error that is fixed by this PR
emoji-button/src/lazyLoad.ts(40,5): semantic error TS2322: Type 'void' is not assignable to type 'string'.