This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix unidoc target #469
Merged
fix unidoc target #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrm, looks like it must have been a bad merge at some point, there are deprecation pointers in that storm package... The builder API one is ok, though it should be updated to the new place. We have 2 points of deprecated code that point around the place since these were all moved to online options. Anyway thanks for the PR |
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
…-upgrade Upgrade sbt launcher script (sbt-extras)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ./sbt unidoc target is failing with errors like
[error] /Users/fkaelin/workspace/github/summingbird/summingbird-storm/src/main/scala/com/twitter/summingbird/storm/option/SummerOptions.scala:42: OnlineSuccessHandler is already defined as value OnlineSuccessHandler
[error] case class OnlineSuccessHandler(handlerFn: Unit => Unit)
There are duplicate type definitions in the online and storm packages, which compiles fine due to shadowing but the docs don't seem to like that. With this change the unidoc target succeeds (I want/need it as I use Dash for documentation browsing)
Not sure this is the right way to go about it, ./sbt test failed with a java.lang.OutOfMemoryError: Java heap space. There is also duplicate code in
summingbird/summingbird-builder/src/main/scala/com/twitter/summingbird/builder/package.scala
Line 66 in cbfb833