This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Split the scalding platform out into packages #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8158cd7.
Add in remaining type aliases
| @@ -27,12 +28,12 @@ import Conversion.asMethod | |||
| /** Services and Stores are very similar, but not exact. | |||
| * This shares the logic for them. | |||
| */ | |||
| class BatchedOperations(batcher: Batcher) { | |||
| private[scalding] class BatchedOperations(batcher: Batcher) { | |||
There was a problem hiding this comment.
why? These look pretty useful for Tsar or others doing operations with batches?
There was a problem hiding this comment.
I couldn't see any uses outside of the scalding platform for it currently. I'd rather be defensive about whats public and not so we know what's safe to change and not? If spark uses it then it might move again, so we don't need more type aliases?
There was a problem hiding this comment.
If you want to keep it public i'll add the type alias in scalding and remove it ?
|
If we remove the private, I mentioned above, and this goes green, I think it is good to merge. |
johnynek
added a commit
that referenced
this pull request
Feb 6, 2014
…form Split the scalding platform out into packages
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
Moments returns NaN when count is too low for higher order statistics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to iterate on the scalding platform by separating more dense files the single folder out into its components to see what should live where