Improve Vertica support in scalding-db #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
reviewed
Mar 23, 2017
| val typeName = q""" | ||
| val $typeNameTerm = $rsmdTerm.getColumnTypeName(${pos + 1}) | ||
| val $typeNameTerm = $rsmdTerm.getColumnTypeName(${pos + 1}).toUpperCase(java.util.Locale.US) |
There was a problem hiding this comment.
I'm confused by this. Can you comment how this works for Vertica if it expects non upper cased?
There was a problem hiding this comment.
Oh. It's matched in the case matching below.
benpence
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(AITOOLS-4225, ADI-2692)
I've been attempting to read data from Vertica using scalding-db. I've found that a few of Vertica's type names differ slightly from MySQL's type names, but other than that scalding-db has worked.
This pull request widens the set of mapped type names. It includes unit tests to verify the new type names are accepted. I've tested this with a simple exporter for a Vertica table containing
date,varchar, andintegercolumns.