Cache boxed classes #1501
Merged
Cache boxed classes #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cache's the Boxes when we can, to make them much harder to Exhaust. Also the Macros will now supply an ID to enable them to be cached
| @@ -0,0 +1,31 @@ | |||
| /* | |||
| Copyright 2014 Twitter, Inc. | |||
|
Addressed all the comments i think |
| val untypedRes = Option(boxedCache.get(cls)) match { | ||
| case Some(r) => r | ||
| case None => | ||
| val r = next[K]() |
There was a problem hiding this comment.
if you did the Any here instead of K you would not need the cast in putIfAbsent, right?
|
👍 MWG |
…eBoxedClasses Conflicts: scalding-serialization/src/main/scala/com/twitter/scalding/serialization/Boxed.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it far harder to exhaust boxed classes. The macros now inherit from a class providing a sane equals and hash code. They supply the class name they operate on as their ID to this parent class. Includes test that runs through a few primitive types and a custom case class.