A serialization error we were seeing in repl usage #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two things: we only expect to use toPipe internally, marking it package private helps with where it gets used. Also the error stems from merging of flowdefs which need to copy the Boxed info between them
|
I don't see why this fixes it. Why isn't calling toPipe their okay? |
johnynek
added a commit
that referenced
this pull request
Jul 21, 2015
A serialization error we were seeing in repl usage
|
toPipe there should be fine, it just seemed wrong since we'd be doing the operations twice. though not likely to produce an incorrect result The fix was the other case, there is a few paths from which we merge flowdef's, and i guess our updater stuff was missing those. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that should fail followed by fix