Move OrderedSerialization into zero-dep scalding-serialization module #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,6 +50,8 @@ class KryoHadoop(config: Config) extends KryoInstantiator { | |||
| newK.register(classOf[com.twitter.algebird.HyperLogLogMonoid], new HLLMonoidSerializer) | |||
| newK.register(classOf[com.twitter.algebird.Moments], new MomentsSerializer) | |||
| newK.addDefaultSerializer(classOf[com.twitter.algebird.HLL], new HLLSerializer) | |||
| // Don't serialize Boxed instances using Kryo. | |||
| newK.addDefaultSerializer(classOf[com.twitter.scalding.serialization.Boxed[_]], new ThrowingSerializer) | |||
There was a problem hiding this comment.
Did you manage to test this?
There was a problem hiding this comment.
No, I didn't, but it should not be hard to do. I'll add such a test.
|
LGTM --> test as a follow up pr seems fine with me. |
ianoc
added a commit
that referenced
this pull request
May 14, 2015
Move OrderedSerialization into zero-dep scalding-serialization module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty general code and nice to have it not so tightly coupled to scalding. Was really easy to do this refactor, so there really is not a coupling.