Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new ExecutionApp tutorial #1196

Merged
merged 13 commits into from
Feb 18, 2015
Merged

Add a new ExecutionApp tutorial #1196

merged 13 commits into from
Feb 18, 2015

Conversation

reconditesea
Copy link
Contributor

Create a tutorial of using Execution in a stand-alone scala/java application.

@reconditesea
Copy link
Contributor Author

To close Issue #1192

@@ -430,4 +431,25 @@ object ScaldingBuild extends Build {
)
}
)

lazy val executionTutorial = Project(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a whole separate project here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a project for tutorial yet. Not sure if that's designed. I created this seprate project for execution only, because in the example I want to show how to run the job as a pure scala/java application. Therefore I need the com.twitter.scalding.tutorial package to be built into the jar.

- scala: 2.10.4
env: BUILD="test execution tutorials"
script:
- "scripts/build_assembly_no_test.sh scalding-core"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to do this? I think just running the assembly on the next target will do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without build scalding-core, travis gave me this failure:
https://travis-ci.org/twitter/scalding/jobs/50681252

@ianoc
Copy link
Collaborator

ianoc commented Feb 17, 2015

Doesn't merge green anymore, other than that, lgtm. @reconditesea merge issues?

- scala: 2.10.4
env: BUILD="test execution tutorials"
script:
- "scripts/build_assembly_no_test.sh scalding-core"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this with the fixes you put in place in the bash script? I'm trying to minimize the time the tests take here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, have removed this and merged with most recent develop. It's
merge-green now.

On Tue, Feb 17, 2015 at 4:17 PM, P. Oscar Boykin notifications@github.com
wrote:

In .travis.yml
#1196 (comment):

@@ -96,3 +96,10 @@ matrix:
script:
- "scripts/build_assembly_no_test.sh scalding-core"
- "scripts/test_typed_tutorials.sh"
+

    • scala: 2.10.4
  •  env: BUILD="test execution tutorials"
    
  •  script:
    
  •  - "scripts/build_assembly_no_test.sh scalding-core"
    

do we still need this with the fixes you put in place in the bash script?
I'm trying to minimize the time the tests take here.


Reply to this email directly or view it on GitHub
https://github.com/twitter/scalding/pull/1196/files#r24868820.

johnynek added a commit that referenced this pull request Feb 18, 2015
@johnynek johnynek merged commit 83eb5c3 into develop Feb 18, 2015
@johnynek johnynek deleted the klin_execution_tutorial branch February 18, 2015 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants