update status badge colors and contrast #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what contrast checker did you use? Some of these look a little fuzzy, and I'm not entirely sure why... it may be the drop shadow color. I may tweak them a bit more, but I want to make sure I keep them at a reasonable contrast level. |
willnorris
approved these changes
Oct 12, 2021
|
I played around, and it's definitely the drop shadow. Even pulling them in by a few pixels makes it look a lot sharper. I'll toy with that in a future change. |
|
It's webaim, for reference. I don't think I touched the drop shadow... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to tweak some of the colors to get white or black text to pass the contrast checker.