Skip to content
This repository has been archived by the owner on Jul 2, 2020. It is now read-only.

Compare responses with xml Content-Type #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compare responses with xml Content-Type #72

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2018

We need to compare xml responses, therefore I wrote a XmlLifter which simply converts the xml to json.

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Lukas Banduch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

codecov-io commented Apr 5, 2018

Codecov Report

Merging #72 into master will decrease coverage by 0.6%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   35.04%   34.43%   -0.61%     
==========================================
  Files          29       30       +1     
  Lines         799      816      +17     
  Branches       34       34              
==========================================
+ Hits          280      281       +1     
- Misses        519      535      +16
Impacted Files Coverage Δ
...ain/scala/com/twitter/diffy/lifter/XmlLifter.scala 0% <0%> (ø)
...in/scala/com/twitter/diffy/lifter/HttpLifter.scala 86.2% <11.11%> (-13.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7894459...9b2d671. Read the comment docs.

;
import scala.xml.{Elem, Node, NodeSeq}

object XmlLifter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than create an XmlLifter here and adding a dependency on org.json4s, please use the existing jsoup dependency and use HtmlLifter to also lift xml.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants