Fix warnings #172
Merged
Fix warnings #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was always more safe, but under Python 3.6+ it also avoids warnings about invalid escapes.
Read file as binary. This is accepted by ast.parse(). Previously the mode "U" (universal newlines) was used, but this is deprecated since Python 3.4 and scheduled for removal in 3.9. While universal newlines is still present as a feature, the syntax to enable it is different for Python 2 vs 3, so reading as a binary is easier. Use open() in a 'with' statement to ensure that the file is properly closed even when reading fails. It's also shorter. The docstring referred to the 'compile' module and the 'MyTransformer' class, both of which are no longer used since we switched to parsing with the 'ast' module. This docstring and also the one of parse() were updated.
This avoids a warning when testing under Python 3.6.
Instead of using inspect.getargspec(), we now hardcode the expected values. This simplifies the test code and avoids a deprecation warning under Python 3.
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 69.55% 69.84% +0.29%
==========================================
Files 27 27
Lines 3616 3615 -1
Branches 785 823 +38
==========================================
+ Hits 2515 2525 +10
+ Misses 832 825 -7
+ Partials 269 265 -4
Continue to review full report at Codecov.
|
glyph
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes four warnings that were shown when running
pytest -Wdunder Python 3.6.There is one remaining warning, but that does not reside in pydoctor itsefl:
This issue has been fixed in CacheControl already, but there hasn't been a release since the fix was integrated.