Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #941 +/- ##
===========================================
- Coverage 100.00% 99.91% -0.09%
===========================================
Files 63 63
Lines 4857 4830 -27
Branches 201 201
===========================================
- Hits 4857 4826 -31
- Misses 0 3 +3
- Partials 0 1 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
(for real these are too many twisted versions though)
adiroiban
approved these changes
Aug 19, 2026
| uses: actions/setup-python@v7 | ||
| with: | ||
| python-version: "3.11" | ||
| python-version: "3.14" |
Member
There was a problem hiding this comment.
This is ok.
One minor optimization, that we have in twisted/twisted.
You can define a global env variable for "default python version" and the use it everywhere.
In this way, future updates will require fewere changes
Member
Author
There was a problem hiding this comment.
Thanks for calling this out; I think I'll fix it in a follow-up and land this as-is. Hopefully it will be less error-prone next time :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #940