Skip to content

remove end-of-life python 3.9 from support matrix - #941

Merged
glyph merged 8 commits into
trunkfrom
nopy39
Aug 19, 2026
Merged

remove end-of-life python 3.9 from support matrix#941
glyph merged 8 commits into
trunkfrom
nopy39

Conversation

@glyph

@glyph glyph commented Aug 19, 2026

Copy link
Copy Markdown
Member

fixes #940

@glyph
glyph requested a review from a team as a code owner August 19, 2026 02:25
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.91%. Comparing base (cdcb0cd) to head (9573758).

Additional details and impacted files
@@             Coverage Diff             @@
##             trunk     #941      +/-   ##
===========================================
- Coverage   100.00%   99.91%   -0.09%     
===========================================
  Files           63       63              
  Lines         4857     4830      -27     
  Branches       201      201              
===========================================
- Hits          4857     4826      -31     
- Misses           0        3       +3     
- Partials         0        1       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

glyph added 2 commits August 18, 2026 19:52
(for real these are too many twisted versions though)

@adiroiban adiroiban left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. thanks!

uses: actions/setup-python@v7
with:
python-version: "3.11"
python-version: "3.14"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok.
One minor optimization, that we have in twisted/twisted.

You can define a global env variable for "default python version" and the use it everywhere.

In this way, future updates will require fewere changes

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for calling this out; I think I'll fix it in a follow-up and land this as-is. Hopefully it will be less error-prone next time :)

@glyph
glyph merged commit 3f47b65 into trunk Aug 19, 2026
18 checks passed
@glyph
glyph deleted the nopy39 branch August 19, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

end of life python3.9

2 participants