Improve tests #38
Merged
Improve tests #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the spec for #endpoint_url. It also didn't fit inside the describe block for the .new method.
The same string was used everywhere.
* Changed some context descriptions * Use expect_any_instance instead of allow_any_instance * Put user_agent spec after the block spec so all API key specs are grouped together.
They were only used in two places in the file.
No need to repeat "Fixture.get" for each test.
Contributor
There was a problem hiding this comment.
noticed we changed to described_class in another test, do it here too?
(although I think we should use some other more appropriate matcher)
Member
Author
There was a problem hiding this comment.
I just thought it looks weird checking that described_class.new is a described_class. It's easier to understand if its explicit, but the "correct way" would probably be to use described_class here too.
"s" is not a vowel :)
… even if we have no posts yet
Contributor
|
I think this was an improvement, merge? |
Member
Author
|
Yes, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some small improvements to the tests.