Skip to content
This repository was archived by the owner on Jun 15, 2019. It is now read-only.

Conversation

@paynerc
Copy link
Contributor

@paynerc paynerc commented Jan 25, 2019

This PR implements the reconnecting state callbacks [TVIRoomDelegate room: isReconnectingWithError:] and [TVIRoomDelegate didReconnectToRoom:] and picks up the 2.7 release.

Copy link
Contributor

@ceaglest ceaglest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but we should also update: AVPlayerExample/ViewController.m

@paynerc
Copy link
Contributor Author

paynerc commented Jan 25, 2019

Updated AVPlayerExample

Copy link
Contributor

@ceaglest ceaglest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 After live discussion that we will use logging for now.

Copy link
Contributor

@ceaglest ceaglest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the typo fix as well.

@paynerc paynerc merged commit 03748f7 into master Feb 14, 2019
@paynerc paynerc deleted the RCP/task/ISDK-2356 branch February 14, 2019 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants