Skip to content

JSDK-2770-QuickstartMobileUI #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2020
Merged

Conversation

PikaJoyce
Copy link
Contributor

@PikaJoyce PikaJoyce commented May 5, 2020

Redesigning the UI on remote reconnection example. The UI has been made more friendly for different devices including tablets on landscape/portrait mode. I will apply similar styling in other examples in another PR.

On Chrome:
quickstartUI

On Safari:
quickstartUISAFARI

on iOS Safari:
Image from iOS
Image from iOS (1)

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Copy link
Collaborator

@manjeshbhargav manjeshbhargav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PikaJoyce Great job! The changes look so simple. Please confirm that its working with all browsers that we support: Chrome, Firefox, Safari, Android Chrome, iOS Safari, Edge (you can download for mac).

@manjeshbhargav
Copy link
Collaborator

@PikaJoyce Please cut a separate PR for the other examples.

@PikaJoyce
Copy link
Contributor Author

PikaJoyce commented May 7, 2020

Double checked for

  • Chrome
  • Edge
  • Safari
  • iOS Safari
  • FireFox
  • Android Chrome

@PikaJoyce PikaJoyce merged commit ac8006d into twilio:master May 7, 2020
@PikaJoyce PikaJoyce deleted the JSDK-2770 branch May 7, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants