Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIDEO-12945 Upgrade to twilio-video@2.27.0 and @twilio/video-processors@2.0.0 #808

Merged
merged 5 commits into from
Jun 30, 2023
Merged

VIDEO-12945 Upgrade to twilio-video@2.27.0 and @twilio/video-processors@2.0.0 #808

merged 5 commits into from
Jun 30, 2023

Conversation

manjeshbhargav
Copy link
Collaborator

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

  • Upgrade twilio-video to 2.27.0.
  • Upgrade @twilio/video-processors to 2.0.0.
  • Debounce is disabled for desktop Chrome.
  • On desktop Chrome and browsers not supporting SIMD, switch to 640x480 when BackgroundProcessor is added.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@manjeshbhargav manjeshbhargav self-assigned this Jun 30, 2023
charliesantos
charliesantos requested changes Jun 30, 2023
View reviewed changes
src/components/VideoProvider/useBackgroundSettings/useBackgroundSettings.ts Outdated
// Disable debounce only on desktop Chrome as other browsers either
// do not support WebAssembly SIMD or they degrade performance.
debounce: !isDesktopChrome,
pipeline: Pipeline.WebGL2,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebGL2 is already the default. I think we can remove this.

src/components/VideoProvider/useBackgroundSettings/useBackgroundSettings.ts Outdated
fitType: ImageFit.Cover,
pipeline: Pipeline.WebGL2,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. WebGL2 is already the default. I think we can remove this.

@manjeshbhargav manjeshbhargav merged commit da482d5 into master Jun 30, 2023
@manjeshbhargav manjeshbhargav deleted the twilio-video-2-27-0-video-processors-2-0-0 branch June 30, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliesantos charliesantos charliesantos approved these changes

Assignees

@manjeshbhargav manjeshbhargav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manjeshbhargav @charliesantos