Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store gcloud service account credentials in proper JSON format. #779

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

manjeshbhargav
Copy link
Collaborator

@manjeshbhargav manjeshbhargav commented Jan 10, 2023

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

Description

For some reason, when we download the service account credentials, it is stored in the following format:

{
  ...
}

some-hex-number

This results in the application server's JSON parser failing to parse the credentials. So, this PR fixes the problem by removing the hexadecimal number from the output.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@manjeshbhargav manjeshbhargav merged commit a967f6b into master Jan 10, 2023
@manjeshbhargav manjeshbhargav deleted the fix-serviceAccountKeyJson-import branch January 10, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants