Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM scripts to allow usage in Windows #744

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Aug 24, 2022

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR updates the NPM scripts to remove linux-only commands, which will allow npm start to be run on windows. This change updates the About modal to import the App's version number directly from package.json. I have verified that, after running npm run build that the version number is the only part of package.json that ends up in the final bundle. All other unused parts of package.json are not included.

Resolves: #743

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza merged commit 0711b6b into master Aug 25, 2022
@timmydoza timmydoza deleted the fix-windows-build branch August 25, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when run npm start
2 participants