Update NPM scripts to allow usage in Windows #744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR updates the NPM scripts to remove linux-only commands, which will allow
npm start
to be run on windows. This change updates the About modal to import the App's version number directly from package.json. I have verified that, after runningnpm run build
that the version number is the only part of package.json that ends up in the final bundle. All other unused parts of package.json are not included.Resolves: #743
Burndown
Before review
npm test
Before merge