Video 10586 synk pr #733
Video 10586 synk pr #733
Conversation
| @@ -25,7 +24,7 @@ function AboutDialog({ open, onClose }: PropsWithChildren<AboutDialogProps>) { | |||
| <DialogContent> | |||
| <DialogContentText>Browser supported: {String(Video.isSupported)}</DialogContentText> | |||
| <DialogContentText>SDK Version: {Video.version}</DialogContentText> | |||
| <DialogContentText>App Version: {appVersion}</DialogContentText> | |||
| <DialogContentText>App Version: {process.env.REACT_APP_VERSION}</DialogContentText> | |||
There was a problem hiding this comment.
Here I wonder what we should have when we run npm start?
Right now it just looks like App Version: with nothing after it. Should we remove it altogether? Or say "See package.json"? Or should we populate REACT_APP_VERSION when we run npm start? What do you think?
There was a problem hiding this comment.
I added it to npm start. I thought about it and figured it is an easy way to check the app version so why not. It was also an easy addition 😄 . On the other hand, I suppose getting rid of it altogether isn't a bad idea either..
jest.config.js
Outdated
| @@ -13,5 +16,9 @@ module.exports = { | |||
| coveragePathIgnorePatterns: ['node_modules', 'src/icons'], | |||
| moduleNameMapper: { | |||
| '.+\\.(css|styl|less|sass|scss|png|jpg|ttf|woff|woff2)$': '<rootDir>/src/__mocks__/fileMock.ts', | |||
| "swiper/react": "<rootDir>/node_modules/swiper/react/swiper-react.js", | |||
| "swiper/css": "<rootDir>/node_modules/swiper/swiper.min.css", | |||
| "swiper/css/bundle": "<rootDir>/node_modules/swiper/swiper-bundle.min.css", | |||
There was a problem hiding this comment.
| "swiper/css/bundle": "<rootDir>/node_modules/swiper/swiper-bundle.min.css", |
Don't think this one is needed.
| @@ -40,6 +40,7 @@ class Filter extends Transform { | |||
|
|
|||
| // Colors normally don't work when using spawn(), so here we re-enable colors. | |||
| process.env.FORCE_COLOR = require('supports-color').stdout.level; | |||
| process.env.REACT_APP_VERSION = require(__dirname + "/../package.json").version | |||
There was a problem hiding this comment.
Github won't let me comment on this, but up on line 20, the URL needs to be updated to:
https://cra.link/deployment
| class="makeStyles-filename-12" | ||
| > | ||
| test1.txt | ||
| </p> | ||
| <p | ||
| class="makeStyles-size-13" | ||
| > | ||
| 120.56 KB | ||
| - Click to open | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
Where did this message go? Should it still be there? I think MessageList.test needs to be updated to handle the new media type.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR updates the following dependencies to the versions listed below:
5.0.0^27.5.2^27.0.1^9.9.0Note that there were additional jest configurations needed in order to test code associated with the SwiperJs library. Please see this solution for more information.
Burndown
Before review
npm testBefore merge