Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release of version 0.6.5 #695

Merged
merged 5 commits into from
Jun 3, 2022
Merged

Prepare release of version 0.6.5 #695

merged 5 commits into from
Jun 3, 2022

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Jun 3, 2022

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

  • N/A

Description

This PR updates the twilio-video version and prepares the app version and changelog for a release. It also increases the maxListeners for the room object to resolve an internal ticket: https://issues.corp.twilio.com/browse/VIDEO-9156

See Changelog: https://github.com/twilio/twilio-video-app-react/blob/prep-release-0.6.5/CHANGELOG.md

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

charliesantos
charliesantos previously approved these changes Jun 3, 2022
@timmydoza
Copy link
Contributor Author

@charliesantos I decided to toss in a quick fix for this issue too: https://issues.corp.twilio.com/browse/VIDEO-8904

Now when you try to share your screen when you don't have the correct system permission set, you will see a useful error (instead of the app failing silently):

image

@timmydoza timmydoza merged commit f91bab9 into master Jun 3, 2022
@timmydoza timmydoza deleted the prep-release-0.6.5 branch June 3, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants