Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve device errors #530

Merged
merged 7 commits into from
May 28, 2021
Merged

Improve device errors #530

merged 7 commits into from
May 28, 2021

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented May 25, 2021

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR improves the device error handling on the Device Selection Screen. It fixes an issue where the microphone was not acquired when the camera permissions were disabled.

Now the user can explicitly deny just their camera or microphone permissions and the app will function as expected. The app will display warnings to the user if they have denied any device permissions.

Resolves #428

Camera still works when microphone permissions are denied:
permissions

Microphone still works when camera permissions are denied:
permissions2

Update: Handle scenario when both audio and video are explicitly denied
permissions3

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza requested a review from olipyskoty May 25, 2021 16:16
olipyskoty
olipyskoty previously approved these changes May 25, 2021
Copy link
Contributor

@olipyskoty olipyskoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and was really easy to follow 👍

@timmydoza timmydoza merged commit bfd77b3 into master May 28, 2021
@timmydoza timmydoza deleted the improve-device-errors branch May 28, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access audio if camera is not enabled
2 participants