Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR improves the device error handling on the Device Selection Screen. It fixes an issue where the microphone was not acquired when the camera permissions were disabled.
Now the user can explicitly deny just their camera or microphone permissions and the app will function as expected. The app will display warnings to the user if they have denied any device permissions.
Resolves #428
Camera still works when microphone permissions are denied:
Microphone still works when camera permissions are denied:
Update: Handle scenario when both audio and video are explicitly denied
Burndown
Before review
npm test
Before merge