Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react app token endpoint #529

Merged
merged 3 commits into from
May 24, 2021
Merged

Fix react app token endpoint #529

merged 3 commits into from
May 24, 2021

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented May 24, 2021 •
edited
Loading

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

A description of what this PR does.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

arturodr and others added 2 commits April 7, 2021 18:33
@arturodr
fix usage of REACT_APP_TOKEN_ENDPOINT
5325add 
if passcode authentication is being used the flag REACT_APP_TOKEN_ENDPOINT currently was being ignored.
Merge branch 'master' into fix-react-app-token-endpoint
536256d
@timmydoza timmydoza mentioned this pull request May 24, 2021
Closed
10 tasks
olipyskoty
olipyskoty approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@olipyskoty olipyskoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@timmydoza timmydoza merged commit 64d923d into master May 24, 2021
@timmydoza timmydoza deleted the fix-react-app-token-endpoint branch May 24, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olipyskoty olipyskoty olipyskoty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timmydoza @olipyskoty @arturodr