Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Participant thumbnail rendering changes #524

Merged
merged 4 commits into from
May 21, 2021
Merged

Participant thumbnail rendering changes #524

merged 4 commits into from
May 21, 2021

Conversation

manjeshbhargav
Copy link
Collaborator

@manjeshbhargav manjeshbhargav commented May 20, 2021 •
edited
Loading

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

@timmydoza @olipyskoty ,

This PR contains the following changes:

  • Thumbnail size reduced to 256x144 instead of 320x180
  • Less gap between thumbnails
  • Flexbox-based ordering of Participants

I am not able to quick deploy the app because I need the current deployment for another purpose. Can one of you deploy and verify the changes? We could sync up tomorrow to try it out.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@manjeshbhargav
Participant thumbnail rendering changes:
2bac396 
* Thumbnail size reduced to 256x144 instead of 320x180
* Less gap between thumbnails
* Flexbox-based ordering of Participants
@manjeshbhargav manjeshbhargav self-assigned this May 20, 2021
olipyskoty
olipyskoty approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@olipyskoty olipyskoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this update looks great 🎉

timmydoza
timmydoza approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@timmydoza timmydoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@manjeshbhargav manjeshbhargav merged commit e751ef0 into master May 21, 2021
@manjeshbhargav manjeshbhargav deleted the thumbnil-rendering-changes branch May 21, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmydoza timmydoza timmydoza approved these changes

@olipyskoty olipyskoty olipyskoty approved these changes

Assignees

@manjeshbhargav manjeshbhargav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manjeshbhargav @timmydoza @olipyskoty