Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video 4739 add track switch off mode to connection options #488

Merged

Conversation

olipyskoty
Copy link
Contributor

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR fixes the bug addressed in #474.

This PR adds the key-value pair trackSwitchOffMode: settings.trackSwitchOffMode to the connectionOptions object in the useConnectionOptions hook as it was previously missing.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added Updated unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@olipyskoty olipyskoty merged commit 7f2c6f8 into master Apr 9, 2021
@olipyskoty olipyskoty deleted the VIDEO-4739-add-trackSwitchOffMode-to-connectionOptions branch April 9, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants