Experimenting with some ConnectOptions and video/screen capture settings. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmydoza
reviewed
Jan 10, 2020
timmydoza
approved these changes
Jan 10, 2020
timmydoza
added a commit
that referenced
this pull request
Mar 6, 2020
…ngs. (#45) * Experimenting with some ConnectOptions and video/screen capture settings. * Add options for standard priority * Update package-lock * Change how video element is muted Co-authored-by: timmydoza <timmydoza@gmail.com>
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
…ngs. (twilio#45) * Experimenting with some ConnectOptions and video/screen capture settings. * Add options for standard priority * Update package-lock * Change how video element is muted Co-authored-by: timmydoza <timmydoza@gmail.com>
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
…ngs. (twilio#45) * Experimenting with some ConnectOptions and video/screen capture settings. * Add options for standard priority * Update package-lock * Change how video element is muted Co-authored-by: timmydoza <timmydoza@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@timmydoza @charliesantos ,
This PR proposes some changes to the ConnectOptions and video/screen capture settings, along with a couple of refactors, which we can discuss. Please take a look when you can.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
A description of what this PR does.
Burndown
Before review
npm testBefore merge