Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages and fix linter #432

Merged
merged 3 commits into from
Feb 23, 2021
Merged

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Feb 23, 2021

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

  • N/A

Description

  • Upgraded twilio-video.js to 2.12.0
  • Upgraded react-scripts from version 4.0.2 to 4.0.3 (to fix an issue with the linter)
  • Upgrade ts-jest from 24.3.0 to 26.5.1 (to match the version of jest installed by react-scripts)
  • Fixed the script for npm run lint so that it is able to lint all files
  • Fixed all warnings and errors reported by linter

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

olipyskoty
olipyskoty previously approved these changes Feb 23, 2021
Copy link
Contributor

@olipyskoty olipyskoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one more warning when i run npx eslint src:
.../twilio-video-app-react/src/types.ts 6:13 warning 'LocalVideoTrack' is already declared in the upper scope on line 1 column 10

not sure if you saw that too, or if that warning can be ignored but thought I would point it out. Otherwise, looks good!

charliesantos
charliesantos previously approved these changes Feb 23, 2021
@timmydoza
Copy link
Contributor Author

Updated PR to add Eslint step to CircleCI pipeline:

image

@timmydoza
Copy link
Contributor Author

I see one more warning when i run npx eslint src:
.../twilio-video-app-react/src/types.ts 6:13 warning 'LocalVideoTrack' is already declared in the upper scope on line 1 column 10

not sure if you saw that too, or if that warning can be ignored but thought I would point it out. Otherwise, looks good!

I'm not seeing that one on my side. This made me realize that there was no Eslint step in the CircleCI pipeline, so I added it. Looks like it isn't showing up there either.

@timmydoza timmydoza merged commit ed2f029 into master Feb 23, 2021
@timmydoza timmydoza deleted the upgrade-packages-fix-linter branch February 23, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants