Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-scripts to 4.0.2 #416

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

olipyskoty
Copy link
Contributor

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

  • Updated react-scripts from version 3.4.4 to 4.0.2
  • This update includes the "fast-refresh" functionality which allows for updates to be made to the code without having to reload the entire page (checkout the gif in this PR!)
  • Found that we couldn't upgrade react-scripts using npm7. Fixed this by downgrading to node version 12 which downgraded npm to version 6
  • This change also made an update to the tsconfig.json file

3796

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

Copy link
Contributor

@timmydoza timmydoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The fast refresh feature will come in handy.

@olipyskoty olipyskoty merged commit 9cd4c9f into master Feb 10, 2021
@olipyskoty olipyskoty deleted the VIDEO-3796-upgrade-react-scripts-to-version-4 branch February 10, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants