AHOYAPPS-13 react app boilerplate #1
Conversation
timmydoza
changed the title
circleci placeholder config
There was a problem hiding this comment.
@timmydoza Great start! I have a few questions and suggestions.
| @@ -0,0 +1,15379 @@ | |||
| { | |||
There was a problem hiding this comment.
@timmydoza I don't think we should commit this file unless we are creating a release/RC tag.
There was a problem hiding this comment.
The NPM docs state that package-lock.json is intended to be committed into source repositories. I think it would be useful to know that the exact same set of dependencies is used between all developers and deployments. Why do you think it should not be committed?
There was a problem hiding this comment.
@timmydoza Because I think if we commit only during creating RC tags, then we can make sure that dependencies are frequently updated. If an RC passes QA, then the release and the particular package-lock.json can be rolled out.
There was a problem hiding this comment.
I agree that we should make sure that dependencies are frequently updated. I think we should leave package-lock.json in the repo, and then run npm update when we create an RC tag to update package-lock.json. The lock file could be useful in development so I think we should keep it around.
There was a problem hiding this comment.
I can see benefit both sides. However, I'm leaning more towards committing it to reduce the risk of us breaking if one of the dependencies have a breaking change. One compromise is to lock to major and minor versions.
* initial create-react-app commit * remove support for PWAs * Remove CRA boilerplate from app * Use twilio favicon * Add prettier and format repo * Add title back to readme * Remove more PWA stuff from index.html * circleci placeholder config * clean up gitignore * Apply new tsconfig rules * Add prettierrc file * Add sections to readme.md * Apply new prettier rules * Add linting script to package.json
* initial create-react-app commit * remove support for PWAs * Remove CRA boilerplate from app * Use twilio favicon * Add prettier and format repo * Add title back to readme * Remove more PWA stuff from index.html * circleci placeholder config * clean up gitignore * Apply new tsconfig rules * Add prettierrc file * Add sections to readme.md * Apply new prettier rules * Add linting script to package.json
* initial create-react-app commit * remove support for PWAs * Remove CRA boilerplate from app * Use twilio favicon * Add prettier and format repo * Add title back to readme * Remove more PWA stuff from index.html * circleci placeholder config * clean up gitignore * Apply new tsconfig rules * Add prettierrc file * Add sections to readme.md * Apply new prettier rules * Add linting script to package.json
https://issues.corp.twilio.com/browse/AHOYAPPS-13
Contributing to Twilio