Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't load webhook authentication if Rack not present #602

Merged
merged 1 commit into from
Mar 9, 2022
Merged

fix: don't load webhook authentication if Rack not present #602

merged 1 commit into from
Mar 9, 2022

Commits on Mar 6, 2022

  1. fix: don't load webhook authentication if Rack not present 

    Now that the webhook authentication requires part of Rack to run, loading the gem in a context that doesn't include Rack fails. For most people this won't happen as it will be used in the context of a web framework and most Ruby web frameworks rely on Rack. However, simple scripts that don't have Rack loaded will fail because the application can't load rack/media_type. In these cases, since Rack is not present, rack middleware won't be helpful either, so we only load the Rack middleware if Rack is present.
    @philnash
    philnash committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    bc8f0a3 View commit details
    Browse the repository at this point in the history