Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSON parser error on timeout response #554

Merged
merged 2 commits into from
Apr 26, 2021
Merged

fix: JSON parser error on timeout response #554

merged 2 commits into from
Apr 26, 2021

Conversation

Maychell
Copy link
Contributor

@Maychell Maychell commented Apr 22, 2021 •
edited
Loading

This PR aims to fix the JSON::ParserError (reported on issue #544) when the client returns a
timeout response by skipping parsing the response body when the response
status code is 504.

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@Maychell
Fix JSON parser error on timeout response
0819735 
This PR aims to fix the JSON::ParserError when the client returns a
timeout response by skipping parsing the response body when the response
status code is 504.
@Maychell Maychell mentioned this pull request Apr 22, 2021
Closed
jp30566347
jp30566347 approved these changes Apr 22, 2021
View reviewed changes
Copy link

@jp30566347 jp30566347 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eshanholtz
eshanholtz approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@eshanholtz eshanholtz changed the title Fix JSON parser error on timeout response fix: JSON parser error on timeout response Apr 26, 2021
@eshanholtz eshanholtz merged commit 3ee9e8f into twilio:main Apr 26, 2021
@dan-jensen dan-jensen mentioned this pull request Dec 10, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp30566347 jp30566347 jp30566347 approved these changes

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maychell @jp30566347 @eshanholtz