added request validation for urls with and without ports #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshanholtz
changed the title
|
Just realized I forgot to add url builder unit tests. Adding now. |
eshanholtz
changed the title
childish-sambino
approved these changes
Oct 24, 2019
Comment on lines
-29
to
+38
| if params_hash.is_a? Enumerable | ||
| expected = build_signature_for(url, params_hash) | ||
| secure_compare(expected, signature) | ||
| else | ||
| expected_signature = build_signature_for(url, {}) | ||
| body_hash = URI.decode_www_form(URI(url).query).to_h['bodySHA256'] | ||
| expected_hash = build_hash_for(params) | ||
| secure_compare(expected_signature, signature) && secure_compare(expected_hash, body_hash) | ||
| unless params_hash.is_a? Enumerable | ||
| body_hash = URI.decode_www_form(parsed_url.query).to_h['bodySHA256'] | ||
| params_hash = build_hash_for(params) | ||
| valid_body = !(params_hash.nil? || body_hash.nil?) && secure_compare(params_hash, body_hash) | ||
| params_hash = {} |
| url += parsed_url.host ? "#{parsed_url.host}:#{parsed_url.default_port}" : '' | ||
| url += parsed_url.path | ||
| url += parsed_url.query ? "?#{parsed_url.query}" : '' | ||
| url += parsed_url.fragment ? "##{parsed_url.fragment}" : '' |
There was a problem hiding this comment.
Don't think there's any tests for this line, but I assume it's the correct syntax.
childish-sambino
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for DI-322