Skip to content

fix: Fix Php Page Template and add tests for Read method #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2022
Merged

fix: Fix Php Page Template and add tests for Read method #356

merged 3 commits into from
Dec 6, 2022

Conversation

@rohith-prakash
Copy link
Contributor

@rohith-prakash rohith-prakash commented Dec 6, 2022

Fixes

Fixes Page Class Template for php and add tests for read method

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

isha689
isha689 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@isha689 isha689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohith-prakash rohith-prakash merged commit 9a30405 into php_list_unit_test Dec 6, 2022
@rohith-prakash rohith-prakash deleted the php_read_test branch December 6, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@isha689 isha689 isha689 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohith-prakash @isha689