Skip to content

chore: java refactoring #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 7, 2022
Merged

chore: java refactoring #355

merged 7 commits into from
Dec 7, 2022

Conversation

@kridai
Copy link
Contributor

@kridai kridai commented Dec 6, 2022

Fixes

Added the changes for the Java Refctoring

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@kridai kridai changed the title Dii 774 java refactoring chore: java refactoring Dec 6, 2022
childish-sambino
childish-sambino approved these changes Dec 6, 2022
View reviewed changes
examples/java/src/main/java/com/twilio/rest/api/v2010/account/call/FeedbackCallSummary.java



private static final long serialVersionUID = 105046036135596L;
Copy link
Contributor

@childish-sambino childish-sambino Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this value have changed?

Copy link
Contributor Author

@kridai kridai Dec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changed because previously here https://github.com/twilio/twilio-oai-generator/blob/main/src/main/java/com/twilio/oai/TwilioJavaGenerator.java#L273-L274 we were still updating the model properties (Enum properties to be exact) after calculating the serial version uid. Ideally serial version uid should be calculated on the result properties that would be added in the file. I have updated this logic order, hence change in the result.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

[twilio-oai-generator-php] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

[twilio-oai-generator-java] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

[twilio-oai-generator-go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

[twilio-oai-generator-node] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kridai kridai requested review from charan678 and removed request for charan678 December 7, 2022 04:37
@kridai kridai merged commit f7915c0 into main Dec 7, 2022
@kridai kridai deleted the DII-774-java-refactoring branch December 7, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charan678 charan678 Awaiting requested review from charan678

1 more reviewer

@childish-sambino childish-sambino childish-sambino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kridai @childish-sambino