Fix reference issue where paramname is referred instead of basename #351
Conversation
childish-sambino
left a comment
childish-sambino
left a comment
There was a problem hiding this comment.
Change looks fine, but need to generate the corresponding PR for twilio-csharp and link it and the GitHub issue here.
| if ({{paramName}} != null) | ||
| { | ||
| p.Add(new KeyValuePair<string, string>("{{paramName}}", {{{vendorExtensions.x-param-to-string}}})); | ||
| p.Add(new KeyValuePair<string, string>("{{{baseName}}}", {{{vendorExtensions.x-param-to-string}}})); |
There was a problem hiding this comment.
This change needs to be done in case of map and array as well and Test by generating code.
|
|
[twilio-oai-generator-php] Kudos, SonarCloud Quality Gate passed!
|
|
[twilio-oai-generator-java] Kudos, SonarCloud Quality Gate passed!
|
|
[twilio-oai-generator-go] Kudos, SonarCloud Quality Gate passed!
|
|
[twilio-oai-generator-node] Kudos, SonarCloud Quality Gate passed!
|
Closes
DII-782 Broken CreateParticipantOptions parameters in v6 of twilio-csharp library
A short description of what this PR does.
In previous versions of the C# library the MessagingBindingAddress and MessagingBindingProxyAddress properties for the CreateParticipantOptions class would translated into MessagingBinding.Address and MessagingBinding.ProxyAddress parameters before submitting to the REST API.
However, in v6 it is now MessagingBindingAddress and MessagingBindingProxyAddress which are ignore by the REST API.
Code v5 vs Code v6.
It should be MessagingBinding.Address and MessagingBinding.ProxyAddress or it won't work. I'm not sure if there are other APIs that have similar dot-notations that are affected in v6.
Checklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-goIf you have questions, please create a GitHub Issue in this repository.