chore: add context template #346
Conversation
| String paramName = path.substring(path.lastIndexOf("{") + 1, path.lastIndexOf("}")); | ||
| String paramName = ""; | ||
| if(path.lastIndexOf("{")!=-1){ | ||
| paramName = path.substring(path.lastIndexOf("{") + 1, path.lastIndexOf("}")); |
There was a problem hiding this comment.
use PathUtils.fetchLastElement(..)
| requiredPathParams.addAll(codegenOperation.pathParams); | ||
| codegenOperation.vendorExtensions = mapOperation(codegenOperation); | ||
|
|
||
| codegenOperation.vendorExtensions.put("hasRequiredFormParams", |
There was a problem hiding this comment.
these should be added under mapOperation(codegenOperation). Let's have one place where all codegenOperation vendorExtensions are added.
| private String apiName; | ||
| private String apiPath; | ||
| private String apiListPath; | ||
| private String apiContextPath; |
There was a problem hiding this comment.
Thoughts about extending ApiResources for PhpApiResources for properties specific to Php library? Since the plan is for all libraries to use ApiResources. @charan678 we did discuss on this today.
| } | ||
|
|
||
| public static String fetchlastPathParam(final String path, final String beginningDelimiter, final String endingDelimiter) { | ||
| if(path.lastIndexOf("{")!=-1) |
There was a problem hiding this comment.
update this to beginningDelimiter
|
[twilio-oai-generator-node] Kudos, SonarCloud Quality Gate passed!
|
|
[twilio-oai-generator-php] SonarCloud Quality Gate failed. |
|
[twilio-oai-generator-java] Kudos, SonarCloud Quality Gate passed!
|
|
[twilio-oai-generator-go] Kudos, SonarCloud Quality Gate passed!
|
Fixes
Checklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-goIf you have questions, please create a GitHub Issue in this repository.