Csharp sonar fixes #336
Csharp sonar fixes #336
Conversation
examples/csharp/Dockerfile
Outdated
| RUN apt-get -y install build-essential | ||
| CMD if [ "$SONAR_TOKEN" = "" ] ; then echo Skipping sonar analysis ; else make cover PROJECT_NAME=twilio_twilio-oai-generator-csharp SONAR_SOURCES="/d:sonar.inclusions=src/Twilio/Rest/**/* /d:sonar.cs.analyzeGeneratedCode=true /d:sonar.exclusions=test/Twilio.Test/**/*" ; fi | ||
| # pipefail prevents errors in a pipeline from being masked. | ||
| CMD ["/bin/bash", "-c", "set -o pipefail && chmod u+r+x /app/twilio-csharp/test.sh && /app/twilio-csharp/test.sh 2>&1 | tee /local/test-report.out"] |
There was a problem hiding this comment.
Should remove the chmod from here and just do it on the file itself.
There was a problem hiding this comment.
Removing chmod causes the tests to fail with error bin/bash: line 1: /app/twilio-csharp/test.sh: Permission denied
| public void TestPost() | ||
| { | ||
| var call = CallResource.Create("testString", ACCOUNT_SID); | ||
| var call = CallResource.Create("testString", Twilio.Http.HttpMethod.Post , ACCOUNT_SID); |
|
[twilio-oai-generator-node] Kudos, SonarCloud Quality Gate passed!
|
|
[twilio-oai-generator-php] Kudos, SonarCloud Quality Gate passed!
|
|
[twilio-oai-generator-go] Kudos, SonarCloud Quality Gate passed!
|
|
[twilio-oai-generator-java] Kudos, SonarCloud Quality Gate passed!
|
Closes
DII-747 Exclude csharp from sonar analysis from github actions and run from scripts
A short description of what this PR does.
Exclude csharp from sonar analysis from github actions and run from scripts. Also integration tests are failing since the argument to create call in call resource was given incorrect in integration tests
Checklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-goIf you have questions, please create a GitHub Issue in this repository.