Skip to content

Commit b826076

Browse files
authored
chore: refactored c# comments in options file (#331)
<!-- We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines, then fill out the blanks below. Please format the PR title appropriately based on the type of change: <type>[!]: <description> Where <type> is one of: docs, chore, feat, fix, test, misc. Add a '!' after the type for breaking changes (e.g. feat!: new breaking feature). **All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.** Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged! e.g. Fixes #1 Closes #2 --> # Fixes # Corrected line/spacing in c# comments in options file. ### Checklist - [x] I acknowledge that all my contributions will be made under the project's license - [ ] Run `make test-docker` - [ ] Verify affected language: - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request - [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) - [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them - [x] I have titled the PR appropriately - [x] I have updated my branch with the main branch - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation about the functionality in the appropriate .md file - [ ] I have added inline documentation to the code I modified If you have questions, please create a GitHub Issue in this repository.
1 parent 81afd02 commit b826076

File tree

13 files changed

+5
-22
lines changed

13 files changed

+5
-22
lines changed

examples/csharp/src/Twilio/Rest/Api/V2010/Account/Call/FeedbackCallSummaryOptions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ public class UpdateFeedbackCallSummaryOptions : IOptions<FeedbackCallSummaryReso
4848
/// <param name="pathSid"> </param>
4949
/// <param name="endDate"> </param>
5050
/// <param name="startDate"> </param>
51-
5251
public UpdateFeedbackCallSummaryOptions(string pathSid, DateTime? endDate, DateTime? startDate)
5352
{
5453
PathSid = pathSid;

examples/csharp/src/Twilio/Rest/Api/V2010/Account/CallOptions.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public class CreateCallOptions : IOptions<CallResource>
4747
/// <summary> Construct a new CreateCallOptions </summary>
4848
/// <param name="requiredStringProperty"> </param>
4949
/// <param name="testMethod"> The HTTP method that we should use to request the `TestArrayOfUri`. </param>
50-
5150
public CreateCallOptions(string requiredStringProperty, Twilio.Http.HttpMethod testMethod)
5251
{
5352
RequiredStringProperty = requiredStringProperty;
@@ -97,7 +96,6 @@ public class DeleteCallOptions : IOptions<CallResource>
9796

9897
/// <summary> Construct a new DeleteCallOptions </summary>
9998
/// <param name="pathTestInteger"> INTEGER ID param!!! </param>
100-
10199
public DeleteCallOptions(int? pathTestInteger)
102100
{
103101
PathTestInteger = pathTestInteger;
@@ -130,7 +128,6 @@ public class FetchCallOptions : IOptions<CallResource>
130128

131129
/// <summary> Construct a new FetchCallOptions </summary>
132130
/// <param name="pathTestInteger"> INTEGER ID param!!! </param>
133-
134131
public FetchCallOptions(int? pathTestInteger)
135132
{
136133
PathTestInteger = pathTestInteger;

examples/csharp/src/Twilio/Rest/Api/V2010/AccountOptions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ public class UpdateAccountOptions : IOptions<AccountResource>
194194

195195
/// <summary> Construct a new UpdateAccountOptions </summary>
196196
/// <param name="status"> </param>
197-
198197
public UpdateAccountOptions(AccountResource.StatusEnum status)
199198
{
200199
Status = status;

examples/csharp/src/Twilio/Rest/FlexApi/V1/CallOptions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ public class UpdateCallOptions : IOptions<CallResource>
3434

3535
/// <summary> Construct a new UpdateCallOptions </summary>
3636
/// <param name="pathSid"> </param>
37-
3837
public UpdateCallOptions(string pathSid)
3938
{
4039
PathSid = pathSid;

examples/csharp/src/Twilio/Rest/FlexApi/V1/Credential/Aws/HistoryOptions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ public class FetchHistoryOptions : IOptions<HistoryResource>
3737

3838
/// <summary> Construct a new FetchCredentialHistoryOptions </summary>
3939
/// <param name="pathSid"> </param>
40-
4140
public FetchHistoryOptions(string pathSid)
4241
{
4342
PathSid = pathSid;

examples/csharp/src/Twilio/Rest/FlexApi/V1/Credential/AwsOptions.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ public class DeleteAwsOptions : IOptions<AwsResource>
3434

3535
/// <summary> Construct a new DeleteCredentialAwsOptions </summary>
3636
/// <param name="pathSid"> </param>
37-
3837
public DeleteAwsOptions(string pathSid)
3938
{
4039
PathSid = pathSid;
@@ -64,7 +63,6 @@ public class FetchAwsOptions : IOptions<AwsResource>
6463

6564
/// <summary> Construct a new FetchCredentialAwsOptions </summary>
6665
/// <param name="pathSid"> </param>
67-
6866
public FetchAwsOptions(string pathSid)
6967
{
7068
PathSid = pathSid;
@@ -123,7 +121,6 @@ public class UpdateAwsOptions : IOptions<AwsResource>
123121

124122
/// <summary> Construct a new UpdateCredentialAwsOptions </summary>
125123
/// <param name="pathSid"> </param>
126-
127124
public UpdateAwsOptions(string pathSid)
128125
{
129126
PathSid = pathSid;

examples/csharp/src/Twilio/Rest/FlexApi/V1/Credential/NewCredentialsOptions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ public class CreateNewCredentialsOptions : IOptions<NewCredentialsResource>
8282

8383
/// <summary> Construct a new CreateCredentialAwsOptions </summary>
8484
/// <param name="testString"> </param>
85-
8685
public CreateNewCredentialsOptions(string testString)
8786
{
8887
TestString = testString;

examples/csharp/src/Twilio/Rest/Versionless/DeployedDevices/FleetOptions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ public class FetchFleetOptions : IOptions<FleetResource>
5959

6060
/// <summary> Construct a new FetchDeployedDevicesFleetOptions </summary>
6161
/// <param name="pathSid"> </param>
62-
6362
public FetchFleetOptions(string pathSid)
6463
{
6564
PathSid = pathSid;

src/main/resources/twilio-csharp/options/CreateOptions.mustache

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
{
55
{{>options/Params}}
66
{{#vendorExtensions.x-required-param-exist}}
7-
{{>options/MethodsComments}}
8-
public Create{{resourceName}}Options({{#requiredParams}}{{{dataType}}} {{#lambda.camelcase}}{{paramName}}{{/lambda.camelcase}}{{^-last}}, {{/-last}}{{/requiredParams}})
7+
{{>options/MethodsComments}} public Create{{resourceName}}Options({{#requiredParams}}{{{dataType}}} {{#lambda.camelcase}}{{paramName}}{{/lambda.camelcase}}{{^-last}}, {{/-last}}{{/requiredParams}})
98
{
109
{{#requiredParams}}
1110
{{paramName}} = {{#lambda.camelcase}}{{paramName}}{{/lambda.camelcase}};

src/main/resources/twilio-csharp/options/DeleteOptions.mustache

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
{{>options/Params}}
55

66
{{#vendorExtensions.x-required-param-exist}}
7-
{{>options/MethodsComments}}
8-
public Delete{{resourceName}}Options({{#requiredParams}}{{{dataType}}} {{#lambda.camelcase}}{{paramName}}{{/lambda.camelcase}}{{^-last}}, {{/-last}}{{/requiredParams}})
7+
{{>options/MethodsComments}} public Delete{{resourceName}}Options({{#requiredParams}}{{{dataType}}} {{#lambda.camelcase}}{{paramName}}{{/lambda.camelcase}}{{^-last}}, {{/-last}}{{/requiredParams}})
98
{
109
{{#requiredParams}}
1110
{{paramName}} = {{#lambda.camelcase}}{{paramName}}{{/lambda.camelcase}};

0 commit comments

Comments
 (0)