Skip to content

Commit 0e2e3ab

Browse files
chore: remove openjdk 8 from java dockerfile (#701)
<!-- We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines, then fill out the blanks below. Please format the PR title appropriately based on the type of change: <type>[!]: <description> Where <type> is one of: docs, chore, feat, fix, test, misc. Add a '!' after the type for breaking changes (e.g. feat!: new breaking feature). **All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.** Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged! e.g. Fixes #1 Closes #2 --> # Fixes # Updated the base image to Eclipse Temurin 8 and added error handling for Maven installation. Also included Git installation and modified the git clone command to use HTTPS. ### Checklist - [x] I acknowledge that all my contributions will be made under the project's license - [ ] Run `make test-docker` - [ ] Verify affected language: - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request - [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) - [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them - [ ] I have titled the PR appropriately - [ ] I have updated my branch with the main branch - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation about the functionality in the appropriate .md file - [ ] I have added inline documentation to the code I modified If you have questions, please create a GitHub Issue in this repository. --------- Co-authored-by: manisha1997 <singhmanisha.250025@gmail.com>
1 parent e4d39eb commit 0e2e3ab

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

examples/java/Dockerfile

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,19 @@
1-
FROM openjdk:8
1+
FROM eclipse-temurin:8-jdk
22

3-
RUN apt-get update && apt-get install maven -y
3+
# Install Maven with proper error handling
4+
RUN apt-get update && \
5+
apt-get install -y --no-install-recommends maven && \
6+
apt-get clean && \
7+
rm -rf /var/lib/apt/lists/*
48

59
WORKDIR /app
10+
# Install git
11+
RUN apt-get update && \
12+
apt-get install -y --no-install-recommends git && \
13+
apt-get clean && \
14+
rm -rf /var/lib/apt/lists/*
15+
16+
# Use HTTPS instead of SSH for git clone
617
RUN git clone https://github.com/twilio/twilio-java.git
718
WORKDIR /app/twilio-java/
819

0 commit comments

Comments
 (0)