Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use ArchUnit to detect JodaTime usage #590

Merged
merged 1 commit into from
Oct 5, 2020
Merged

test: use ArchUnit to detect JodaTime usage #590

merged 1 commit into from
Oct 5, 2020

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Oct 3, 2020 •
edited
Loading

Fixes

use ArchUnit to detect JodaTime usage

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sullis sullis mentioned this pull request Oct 3, 2020
Merged
1 task
@sullis
add unit test: noClassesShouldUseJodaTime
ce41c38 
use ArchUnit to detect JodaTime usage
@sullis sullis force-pushed the noClassesShouldUseJodaTime branch from 7151821 to ce41c38 Compare October 3, 2020 18:10
@sullis sullis changed the title add unit test: noClassesShouldUseJodaTime use ArchUnit to detect JodaTime usage Oct 3, 2020
@childish-sambino childish-sambino changed the title use ArchUnit to detect JodaTime usage test: use ArchUnit to detect JodaTime usage Oct 5, 2020
@childish-sambino childish-sambino merged commit 8b2d600 into twilio:main Oct 5, 2020
@sullis sullis deleted the noClassesShouldUseJodaTime branch January 30, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sullis @childish-sambino