Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Make remember_device account specific #59

Closed
wants to merge 2 commits into from
Closed

Make remember_device account specific #59

wants to merge 2 commits into from

Conversation

Gasparila
Copy link
Contributor

Fixes #58

@MikeRogers0
Copy link
Contributor

Anyone able to merge this? This seems like a fairly important PR.

@vargasx
Copy link
Contributor

vargasx commented Sep 5, 2016

@Gasparila nice work, could you please take a look a specs, when I run them I see this error no implicit conversion of nil into String, could you add a test for the new behavior ?

@Gasparila
Copy link
Contributor Author

Hi Vargasx,

It is working fine in production for use so we will keep it as is. The tests are probably failing because https://github.com/authy/authy-devise/pull/59/files#diff-504e05fb0907b711490ad2748668bd2cR26 assumes the cookie exists. In our experience, however, this cookie is never blank

@MikeRogers0
Copy link
Contributor

I'm happy to fork flexport:master and fix the test if you want @Gasparila @vargasx ?

@vargasx
Copy link
Contributor

vargasx commented Sep 20, 2016

@MikeRogers0 that would be great cc @Gasparila

@MikeRogers0 MikeRogers0 mentioned this pull request Oct 6, 2016
Merged
@Gasparila
Copy link
Contributor Author

Closing in favor of #67

@Gasparila Gasparila closed this Nov 16, 2016
jdejong added a commit to jdejong/authy-devise that referenced this pull request Aug 9, 2017
@jdejong
Merge commit 'e790ac877c62baf8e8eaac846ca7c86148b978e4'
df8a7e2 
* commit 'e790ac877c62baf8e8eaac846ca7c86148b978e4': (43 commits)
  Bump version to 1.8.1
  Always require token when user has an old cookie
  Fix specs
  actually sign out everything
  Fix for twilio#69
  Fixing broken specs broken in twilio#59
  Be backwards compatible with old cookies
  remove leftover byebug
  Make remember_device account specific
  Bump version to 1.8.0
  Update to rails 4.2.7
  Fix token message test
  use before_action instead and fix before_filter deprication warning
  Fix install spec
  Fix tests
  Replaced alias_method_chain with Module#prepend approach
  Making quotes in the locale files consistent
  Add ability to pass in custom text to request sms link.
  Generate the Authy initializer as part of the install generator.
  Adds documentation for the request phone call helper
  ...

# Conflicts:
#	lib/devise-authy/controllers/helpers.rb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gasparila @MikeRogers0 @vargasx