Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBLOCKS-3834 Make AudioDeviceChangeListener optional parameter when calling start() #169

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ocarevs
Copy link
Collaborator

@ocarevs ocarevs commented Dec 3, 2024

Description

Make AudioDeviceChangeListener optional parameter when calling start()

Breakdown

  • AudioDeviceChangeListener parameter when calling AudioSwitch.start() can be omitted or be null in java case.
  • Adding AudioSwitch.addAudioDeviceChangeListener(listener: AudioDeviceChangeListener) to add listener in case the listener was not passed when calling start()
  • Adding AudioSwitch.removeAudioDeviceChangeListener() to remove existing listener.

Validation

  • Unit tests

Additional Notes

[Any additional comments, notes, or information relevant to reviewers.]

Submission Checklist

  • The source has been evaluated for semantic versioning changes and are reflected in gradle.properties
  • The CHANGELOG.md reflects any feature, bug fixes, or known issues made in the source code

@ocarevs ocarevs requested a review from afalls-twilio December 4, 2024 12:25
Copy link
Contributor

@afalls-twilio afalls-twilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make set auduio device listener take null to unset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants