This repository was archived by the owner on Mar 4, 2021. It is now read-only.
fixed error for "Can't use method return value in write context"#254
Closed
clarkewd wants to merge 1 commit intotwilio:masterfrom
Closed
fixed error for "Can't use method return value in write context"#254clarkewd wants to merge 1 commit intotwilio:masterfrom
clarkewd wants to merge 1 commit intotwilio:masterfrom
Conversation
Contributor
|
This is code in the core CI libraries. I'm hesitant to merge this as its not OpenVBX code. I'm monitoring another PR that upgrades the CodeIgniter libraries to hopefully that can get merged and supersede the need to this request. |
Author
|
ah, i see - yes. I think that would be a good solution. thank you for looking at it. |
Contributor
|
Cool. Closing this. Fix will be included in #261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change PHP throws an error:
For notes on why the
empty()function is not necessary see http://stackoverflow.com/questions/1075534/cant-use-method-return-value-in-write-context