Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and twilio-run build #486

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

colossal-toby
Copy link
Contributor

Currently CI tests are failing and twilio-run will not build due to the following typescript error:

error TS2688: Cannot find type definition file for 'wrap-ansi'.
  The file is in the program because:
    Entry point for implicit type library 'wrap-ansi'

This error occurs because the package @types/wrap-ansi does not include an index.d.ts file. This package is no longer required as the package wrap-ansi includes typings, so I have removed the type definition stub from package.json.

Additionally I've declared wrap-ansi as a module in types.d.ts.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: 10c88dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@twilio-labs/serverless-api Patch
twilio-run Patch
create-twilio-function Patch
@twilio-labs/plugin-serverless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AndreLars AndreLars merged commit 3787785 into twilio-labs:main Dec 7, 2023
13 checks passed
Copy link

welcome bot commented Dec 7, 2023

Congratulations on your first contribution to the Serverless Toolkit!
If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource.
If you want to stay up-to-date with Twilio's OSS activities, subscribe here: https://twil.io/oss-updates
And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!

@github-actions github-actions bot mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants