Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(twilio-run): passing a dir doesn't get overriden by cwd #381

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix(twilio-run): passing a dir doesn't get overriden by cwd #381

merged 1 commit into from
Aug 30, 2022

Conversation

philnash
Copy link
Contributor

fixes #335

I broke the ability to pass a directory to twilio-run start in #331. This fixes that, by only setting flags.cwd after the baseDir is set.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@philnash philnash requested a review from dkundel January 18, 2022 01:07
@krisdover
Copy link

Any update on when this one will be released?

@dkundel dkundel merged commit 9f02b32 into main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkundel dkundel dkundel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot set base directory for twilio-run
3 participants
@philnash @krisdover @dkundel