Skip to content

Conversation

@david-amores-anz
Copy link
Contributor

Fixes #227

To be able to deploy functions behind an https proxy, we can now set the proxy URL in an env variable called HTTP_PROXY. This will set the appropriate http agent in the got client.

Testing instructions

  • Have a locally running forward proxy
  • Be on a network behind a https authenticating proxy
  • Set environment variable HTTP_PROXY to have the proxy's url

On main:

  • Run twilio-run deploy inside a function directory
  • Make sure the command hangs at Configuring bare environment and eventually fails

On this branch:

  • Run twilio-run deploy inside a function directory
  • Make sure the deployment succeeds

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@philnash philnash modified the milestones: v3, Post v3 Mar 15, 2021
@philnash
Copy link
Contributor

Sorry for the test fails here. There's one update that needs merging that fixes it. We're about to complete some other work on this that will bring that in, then we can work on getting this branch up to date and merged too.

@david-amores-anz
Copy link
Contributor Author

Cool, thanks for keeping me updated @philnash!

@dkundel dkundel closed this Apr 15, 2021
@dkundel dkundel reopened this Apr 15, 2021
@philnash
Copy link
Contributor

I have merged this, but it wasn't picked up by GitHub. It should go live in the next release which is coming real soon now, I promise!

@philnash philnash closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

twilio-run not working behind https proxy

3 participants