Skip to content

Conversation

@philnash
Copy link
Contributor

@philnash philnash commented Dec 8, 2020

This makes ngrok an optional dependency and handles the error when loading it by shutting down the server and printing a message.

This is intended to help with #205. Still need to investigate installing CLI plugins without optional dependencies.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

This is intended to help with #205. Still need to investigate installing CLI plugins without optional dependencies.
@philnash philnash requested a review from dkundel December 8, 2020 01:52
@philnash
Copy link
Contributor Author

philnash commented Dec 8, 2020

The tests are failing because Express can't be found? That has nothing to do with my changes and the tests are passing locally. Any ideas? 🤷‍♂️

@philnash philnash added this to the Post v3 milestone Feb 25, 2021
@dkundel dkundel closed this Apr 15, 2021
@dkundel dkundel reopened this Apr 15, 2021
@dkundel dkundel merged commit 3061015 into main Apr 15, 2021
@dkundel dkundel deleted the optional-ngrok branch April 15, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants