test: switch to using biome #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
micaswyers-work
approved these changes
Feb 20, 2025
| sid.length === 34 | ||
| ); | ||
| }; | ||
| const validateSid = (prefix, sid) => |
There was a problem hiding this comment.
Is this conversion to an arrow function something that the Biome formatter did?
| @@ -1,2 +1,2 @@ | |||
| const path = require('path'); | |||
| const path = require('node:path'); | |||
There was a problem hiding this comment.
Did the module name change?
bnb
commented
Feb 20, 2025
package.json
Outdated
| "url": "https://github.com/twilio-labs/plugin-token.git" | ||
| }, | ||
| "scripts": { | ||
| "biome:format": "npx @biomejs/biome format --write .", |
There was a problem hiding this comment.
default format command should not include --write
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
micaswyers-work
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches us from ESLint and Prettier to using Biome for linting and formatting. All formatting and linting issues have been addressed by the committed changes.
Contributing to Twilio