ci: enable TurboSnap for Chromatic #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
Status: Do Not Merge
Niznikr
commented
Feb 8, 2023
Comment on lines
+424
to
+425
| - 'packages/paste-design-tokens/tokens/**' | ||
| - 'packages/paste-icons/src/**' |
There was a problem hiding this comment.
These files are pre-processed/built and so require to be specified as externals.
github-actions
bot
added
Area: Infrastructure
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #5353 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Size Change: 0 B Total Size: 897 kB ℹ️ View Unchanged
|
nkrantz
previously approved these changes
Feb 8, 2023
gloriliale
previously approved these changes
Feb 8, 2023
Niznikr
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
gloriliale
previously approved these changes
Feb 8, 2023
nkrantz
previously approved these changes
Feb 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Niznikr
added
Status: Do Not Merge
Niznikr
force-pushed
the
feat/turbosnap
branch
from
a0b38e9 to
59c0bc0
Compare
SiTaggart
approved these changes
Feb 10, 2023
gloriliale
approved these changes
Feb 10, 2023
Niznikr
added
🚀 merge it!
and removed
Status: Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the number of snapshots taken during Chromatic for faster checks and prevent overage costs, we can enable TurboSnap. Going to keep it at
pull_requestfor now for us to stress-test it and figure out how we might want to use it onpushin a future iteration (since it requires packages to be built first). Verifiedpull_requestworks for this with the Chromatic team and based off their example.To test and see the generated dependency graph:
yarnyarn build:storybookdocs/preview-stats.json